[node] Replace node-pre-gyp with prebuild-install #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
node
github_actions
acalcutt
changed the title
acalcutt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to replace node-pre-gyp with prebuild-install. I was also initially trying to use prebuild or prebuildify to make the binary packages, but ended up having trouble getting that to work with draft releases, so I ended up with a custom build script combined with a upload action to get around that. one advantage to that is the binaries can now be packaged locally.
Some benefits of prebuild-install
1.) node-pre-gyp is no longer really supported and i have had to maintain it to keep it working
2.) prebuild-install supports custom local binaries, which node-pre-gyp does not. This would allow a solution to #3770 . It also supports custom http binaries as well. see https://github.com/prebuild/prebuild-install?tab=readme-ov-file#custom-binaries